fix: pagination: bug fixes for simplified pagination #581
+116
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnori-eightfold
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0251d80:
|
rnori-eightfold
changed the title
dkilgore-eightfold
suggested changes
Apr 3, 2023
Show simplified pagination only when there is more than one page
rnori-eightfold
force-pushed
the
rnori-eightfold/simplified-pager-bug-fixes
branch
from
dd74019 to
f191f97
Compare
use pageSize prop instead of pageSizes
there is some extra padding on the top in case of simplified pagination
rnori-eightfold
force-pushed
the
rnori-eightfold/simplified-pager-bug-fixes
branch
from
f191f97 to
646a52d
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
=======================================
Coverage ? 84.81%
=======================================
Files ? 792
Lines ? 17144
Branches ? 6045
=======================================
Hits ? 14540
Misses ? 2538
Partials ? 66 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
When there is single page for simplified pagination, show the last page
rnori-eightfold
force-pushed
the
rnori-eightfold/simplified-pager-bug-fixes
branch
from
9120ffe to
dc14546
Compare
dkilgore-eightfold
suggested changes
Apr 5, 2023
…om:rnori-eightfold/octuple into rnori-eightfold/simplified-pager-bug-fixes
dkilgore-eightfold
suggested changes
Apr 5, 2023
Controls number of pages displayed b/w ... buttons
rnori-eightfold
force-pushed
the
rnori-eightfold/simplified-pager-bug-fixes
branch
from
dfca9d0 to
0251d80
Compare
dkilgore-eightfold
approved these changes
Apr 5, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
pageSizesprop only whenlayouthasPaginationLayoutOptions.SizesJIRA TASK (Eightfold Employees Only):
N/A
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn,yarn storybook. Verify all types of Pagination, Carousel behave as expected.